This repository was archived by the owner on Mar 21, 2022. It is now read-only.
Speed up completion #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function will be called more than once later. Cache the major version for efficiency. Instead of parsing the cmake output with regexes, assume the first line of version output and parse out the major version immediately.
Instead of initalizing all the data as soon as anything is requested, only initialize the lists that are actually needed. Do this by introducing a "getter" for the lists instead of referencing s:cmake_foo directly. The getter checks if the list is empty and then fills it. The many more calls to Version() is mitigated by the previous commit. Currently this achieves nothing of value for the Help() function, but does no harm either.
Osse
changed the title
Owner
|
Thanks for this! It looks great. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thank you for this nice plugin. Very clever to use the output of cmake's --help-* arguments.
I often find myself opening a CMakeLists.txt to do a quick edit then closing
Vim instead of having the file always open. To this end I wanted to speed up
the completion somewhat, hence this PR.